Hi - I just had a quick browse through your source, and I was wondering how one could contribute. Do you accept patch submissions, or would it be at all useful if I post small comments?
A quick question to begin: How complete is your knowledge of the network protocol, and where is it documented?
OK. Just looking at src/mineserver.h/cpp I have some very minor suggestions:
- mineserver.h doesn't seem to use the <set> and <iostream> headers; those can go.
- mineserver.cpp: in main(), you could move the declaration of "arg" inside the loop: "std::string arg(argv)". On the other hand, using getopt.h would probably be an even better approach (one could include a portable version for non-POSIX targets).
- mineserver.cpp: With std::tr1 you have access to a few very good standardized random number generators, might be worth checking out.
- Across other header files, there's a mix between deprecated and modern C headers, <string.h> vs. <cstring> etc. Might be nice to make that uniform.
It'd be great to see this project succeed!
